Merged
Conversation
Use `winapi_util::file::information` in place of `winx::file::get_fileinfo`, which is simpler, except for needing to convert the types, which we need to do because we're ultimately using these values in the [windows `MetadataExt` trait] which uses `u32`. I submitted BurntSushi/winapi-util#7 to propose changing the types upstream. [windows `MetadataExt` trait]: https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html
sunfishcode
force-pushed
the
sunfishcode/update-winx
branch
from
6f31a31 to
71a53e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
winapi_util::file::informationin place ofwinx::file::get_fileinfo,which is simpler, except for needing to convert the types, which we need
to do because we're ultimately using these values in the
windows
MetadataExttrait which usesu32. I submittedBurntSushi/winapi-util#7 to propose changing the types upstream.